Rbarlow ssl verification coverage #537
Conversation
| """ | ||
| Tests for the RepoHandler object. | ||
| """ | ||
| @mock.patch('pulp_rpm.handlers.bind.repolib.bind') |
There was a problem hiding this comment.
Maybe add a blank line above this to separate it logically from the docstring.
There was a problem hiding this comment.
I actually prefer this style, but that's partly because vim makes it look really nice. The real reason is that I really hate wasting vertical space because even with the resolution I have I like having higher information density on my screen when I read. Bet you couldn't guess that in C I really hate when people put curly braces on their own line.
I don't believe that PEP-8 makes a statement one way or the other, but if it does I'd be happy to follow it. Otherwise I'd personally prefer to maintain more information per line of code ☺
|
The tests introduced in test_repolib.py contain a lot of duplicate code. Consider de-duplicating it using helper functions. This would let the unique assertions of each test stand out more. |
|
code coverage is good, PEP8 compliance is good, and all tests pass. Merge at will. |
No description provided.