treat 'epoch' as '0' when it does not exist or is null #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some updateinfo.xml metadata does not contain the `epoch` field in package records. In these cases, Pulp will not be able to find the appropriate RPM. In these cases, we can assume that the epoch should be '0'. This allows Pulp to find the RPM when applying packages to a system. fixes pulp#833
| self.assertTrue(rpms[1]["name"] in ['emoticons', 'patb']) | ||
| for r in rpms: | ||
| self.assertTrue('epoch' in r) | ||
| self.assertTrue(r['epoch'] == '0') |
There was a problem hiding this comment.
Nothing wrong with this, but you could use assertEqual
|
@mhrivnak thanks for the fast review |
beav
added a commit
that referenced
this pull request
Apr 9, 2015
treat 'epoch' as '0' when it does not exist or is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updateinfo.xml metadata does not contain the
epochfield in packagerecords. In these cases, Pulp will not be able to find the appropriate RPM.
In these cases, we can assume that the epoch should be '0'. This allows Pulp to
find the RPM when applying packages to a system.
fixes #833