-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user I can upload comps.xml file. #709
Conversation
Refer to this link for build results (access rights to CI server needed): |
@@ -376,6 +376,11 @@ Metadata | |||
Example format: ``{"group" : <group_id>, "default" : True}`` | |||
|
|||
|
|||
.. note:: | |||
Package_group, package_category and package environment elements can be uploaded also via comps file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/can be uploaded also via/can also be uploaded via/
It looks fine to me, but I am pretty unfamiliar with this, someone else should also take a look. |
from pulp_rpm.devel.client_base import PulpClientTests | ||
|
||
|
||
DATA_DIR = os.path.abspath(os.path.dirname(__file__)) + '/../../../../../../plugins/test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this elsewhere, but it doesn't seem ideal. @rbarlow, do you know of a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Austin wrote:
I've seen this elsewhere, but it doesn't seem ideal. @rbarlow
https://github.com/rbarlow, do you know of a better way?
Eh, for tests I don't think it's so bad. But one option could be to put
the DATA_DIR variable inside pulp_rpm.devel.somewhere and then you could
import that instead.
Fix these two things before merging:
LGTM! |
Refer to this link for build results (access rights to CI server needed): |
closes #287
https://pulp.plan.io/issues/287