Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I can upload comps.xml file. #709

Merged
merged 1 commit into from
Sep 24, 2015
Merged

As a user I can upload comps.xml file. #709

merged 1 commit into from
Sep 24, 2015

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Aug 19, 2015

@pulpbot
Copy link
Member

pulpbot commented Sep 8, 2015

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp_rpm-pr/134/

@@ -376,6 +376,11 @@ Metadata
Example format: ``{"group" : <group_id>, "default" : True}``


.. note::
Package_group, package_category and package environment elements can be uploaded also via comps file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/can be uploaded also via/can also be uploaded via/

@asmacdo
Copy link
Contributor

asmacdo commented Sep 18, 2015

It looks fine to me, but I am pretty unfamiliar with this, someone else should also take a look.

from pulp_rpm.devel.client_base import PulpClientTests


DATA_DIR = os.path.abspath(os.path.dirname(__file__)) + '/../../../../../../plugins/test'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this elsewhere, but it doesn't seem ideal. @rbarlow, do you know of a better way?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Austin wrote:

I've seen this elsewhere, but it doesn't seem ideal. @rbarlow
https://github.com/rbarlow, do you know of a better way?

Eh, for tests I don't think it's so bad. But one option could be to put
the DATA_DIR variable inside pulp_rpm.devel.somewhere and then you could
import that instead.

@bowlofeggs
Copy link

Fix these two things before merging:

  1. Make sure there are docblocks on all the methods, and the new parameters are documented in the existing methods.

  2. Add a few more assertions to that one test I mentioned.

LGTM!

@pulpbot
Copy link
Member

pulpbot commented Sep 24, 2015

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp_rpm-pr/139/

@ipanova ipanova merged commit a159192 into pulp:2.7-dev Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants