Distribution storage path no longer dependant on hostname and PRNG. #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use os.path.relpath instead of str.lstrip when determining the relative path of a distribution file during content import. The Python method `str.lstrip` takes a list of chars, but this is treated as a set of characters to strip from the left side of the string, *not* as a substring to remove[0]. This was problematic for many reasons, but would (rather entertainingly) determine the relative path for distribution files based on the hostname of the worker and the psuedo-random number generator used by tempdir and uuid. to '/var/cache/pulp/<worker>@<host>/<task-uuid>/<temp-dir>/' [0] https://docs.python.org/2/library/stdtypes.html#str.lstrip closes pulp#1654
|
ok test |
jeremycline
added a commit
that referenced
this pull request
Feb 11, 2016
Distribution storage path no longer dependant on hostname and PRNG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use os.path.relpath instead of str.lstrip when determining the relative
path of a distribution file during content import.
The Python method
str.lstriptakes a list of chars, but this istreated as a set of characters to strip from the left side of the
string, not as a substring to remove[0]. This was problematic for many
reasons, but would (rather entertainingly) determine the relative path
for distribution files based on the hostname of the worker and the
psuedo-random number generator used by tempdir and uuid. We temporarily saved content
to '/var/cache/pulp/@///'.
[0] https://docs.python.org/2/library/stdtypes.html#str.lstrip
closes #1654