Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ISO rsync distributor #940

Merged
merged 1 commit into from Jul 26, 2016
Merged

Adds ISO rsync distributor #940

merged 1 commit into from Jul 26, 2016

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented Jul 24, 2016

bmbouter
bmbouter reviewed Jul 24, 2016
View reviewed changes
docs/tech-reference/iso-rsync-distributor.rst

Configuration
=============
Here's an example of rpm_rsync_distributor configuration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Here's//Here is/
s/of //

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dkliban
Copy link
Member Author

dkliban commented Jul 25, 2016

Please rereview

bmbouter
bmbouter reviewed Jul 25, 2016
View reviewed changes
docs/tech-reference/iso-rsync-distributor.rst

Configuration
=============
Here is an example rpm_rsync_distributor configuration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the rpm_rync_distributor the right label here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not

@bmbouter bmbouter added the LGTM label Jul 25, 2016
@bmbouter
Copy link
Member

@dkliban You've done a really great job on this. I'm very proud of this work being added to Pulp!

@bmbouter
Copy link
Member

The full test plan all worked so I added the LGTM

@dkliban dkliban merged commit 76976da into pulp:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmbouter bmbouter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkliban @bmbouter