Use templatetag to escape Django syntax characters in templates
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end_templatetag = '{%% endverbatim pulp_%s_escape_method %%}' % tag_name | ||
| template = template.replace(start_tag, start_templatetag + start_tag) | ||
| template = template.replace(end_tag, end_tag + end_templatetag) | ||
| def substitute_special_chars(template): |
There was a problem hiding this comment.
Rather than defining functions within a function, these should be private static methods in the containing namespace (I think it's RpmBase here).
There was a problem hiding this comment.
@seandst,
My thought was that at least one of them is highly specific, it makes some assumptions about the input and has no use at all outside the outer function. I can probably substitute it with a lambda function in a parameter but it will be less readable, imho:
Instead of this:
template = tag_re.sub(generate_tag_replacement_str, template)
I can write this:
template = tag_re.sub(lambda mobj: mobj.group(1) + substitute_special_chars(mobj.group(2)) + mobj.group(3),
template)
And by private do you mean to start the name with two underscores?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2135
https://pulp.plan.io/issues/2135