This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Add validation exceptions to plugin API #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
approved these changes
Jul 3, 2019
bmbouter
pushed a commit
to bmbouter/pulp_ansible
that referenced
this pull request
Jul 3, 2019
The import_collection task was used by the Galaxy API to receive an artifact from mazer, but this reuses it for a new viewset in the Django API. Required PR: pulp/pulpcore-plugin#111 https://pulp.plan.io/issues/5050 closes #5050
bmbouter
pushed a commit
to bmbouter/pulp_ansible
that referenced
this pull request
Jul 3, 2019
The import_collection task was used by the Galaxy API to receive an artifact from mazer, but this reuses it for a new viewset in the Django API. Required PR: pulp/pulpcore-plugin#111 https://pulp.plan.io/issues/5050 closes #5050
bmbouter
pushed a commit
to bmbouter/pulp_ansible
that referenced
this pull request
Jul 3, 2019
The import_collection task was used by the Galaxy API to receive an artifact from mazer, but this reuses it for a new viewset in the Django API. Required PR: pulp/pulpcore-plugin#111 https://pulp.plan.io/issues/5050 closes #5050
The `DigestValidationError` and `SizeValidationError` validation exceptions were not available in the plugin API. Now they are available in `pulpcore.plugin.exceptions` package. https://pulp.plan.io/issues/5077 closes #5077
bmbouter
force-pushed
the
add-exceptions-to-plugin-api
branch
from
3ddd799
to
1c9da18
Compare
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 42.64% 42.64%
=======================================
Files 22 22
Lines 734 734
=======================================
Hits 313 313
Misses 421 421Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DigestValidationErrorandSizeValidationErrorvalidationexceptions were not available in the plugin API. Now they are available
in
pulpcore.plugin.exceptionspackage.https://pulp.plan.io/issues/5077
closes #5077