This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Test building docs against PRs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue4403
branch
2 times, most recently
from
d4f032c
to
13000c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 42.53% 42.53%
=======================================
Files 22 22
Lines 710 710
=======================================
Hits 302 302
Misses 408 408Continue to review full report at Codecov.
|
daviddavis
force-pushed
the
issue4403
branch
5 times, most recently
from
05dfaae
to
d695fcd
Compare
|
I think a separate job would be almost as efficient and a little bit clearer. |
daviddavis
force-pushed
the
issue4403
branch
from
d695fcd
to
d8a0a44
Compare
Note that I am not creating a separate job for testing the docs. We're limited by the number of concurrent jobs in the Pulp org so I figure it's more efficient to execute the docs check during the normal test since it adds 30-60 seconds. fixes #4403 https://pulp.plan.io/issues/4403
daviddavis
force-pushed
the
issue4403
branch
from
d8a0a44
to
d6196a5
Compare
daviddavis
commented
Feb 19, 2019
| @@ -7,10 +7,12 @@ python: | |||
| - "3.6" | |||
| - "3.7" | |||
| env: | |||
| matrix: | |||
| - DJANGO_MAX=2.2.100 DB=postgres TEST=pulp | |||
There was a problem hiding this comment.
Not sure if we need this DJANGO_MAX environment variable? I can add it back if we do.
bmbouter
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I am not creating a separate job for testing the docs. We're
limited by the number of concurrent jobs in the Pulp org so I figure
it's more efficient to execute the docs check during the normal test
since it only adds 30-60 seconds.
fixes #4403
https://pulp.plan.io/issues/4403