This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Remove duplicates does not work properly if there is multiple content… #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Mar 29, 2019
Required PR: pulp/pulpcore-plugin#79 Required PR: pulp/pulpcore-plugin#81 closes #4173 closes #4178 https://pulp.plan.io/issues/4173 https://pulp.plan.io/issues/4178
… types in the repo. closes #4604 https://pulp.plan.io/issues/4604
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Mar 29, 2019
Required PR: pulp/pulpcore-plugin#79 Required PR: pulp/pulpcore-plugin#81 closes #4173 closes #4178 https://pulp.plan.io/issues/4173 https://pulp.plan.io/issues/4178
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Mar 29, 2019
Required PR: pulp/pulpcore-plugin#81
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 1, 2019
Required PR: pulp/pulpcore-plugin#81
ipanova
added a commit
to ipanova/pulp_docker
that referenced
this pull request
Apr 1, 2019
Required PR: pulp/pulpcore-plugin#81
|
Can this PR be closed now that there is a second one? |
|
Yes I lgtm'd the other one which also has Travis passing. I'm closing this one. |
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 42.93% 42.87% -0.06%
==========================================
Files 22 22
Lines 722 723 +1
==========================================
Hits 310 310
- Misses 412 413 +1
Continue to review full report at Codecov.
|
|
It's all good I was doing the same thing when Travis was being strange. Thank you for the PRs! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… types in the repo.
closes #4604
https://pulp.plan.io/issues/4604
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html