Skip to content

Commit

Permalink
Replaced incorrect use of 'filename' with 'natural_keys()' in error log.
Browse files Browse the repository at this point in the history
fixes #9427.
[nocoverage]
  • Loading branch information
ggainey authored and dralley committed Sep 23, 2021
1 parent 55b33d0 commit 6e18f2e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES/9427.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Taught a remote-artifact error path to not assume 'filename' was valid for all content.
4 changes: 2 additions & 2 deletions pulpcore/plugin/stages/artifact_stages.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ async def _handle_remote_artifacts(self, batch):
log.warning(
msg.format(
rp=d_artifact.relative_path,
c=d_content.content.filename,
c=d_content.content.natural_key(),
rname=d_artifact.remote.name,
ap=avail_paths,
)
Expand All @@ -365,7 +365,7 @@ async def _handle_remote_artifacts(self, batch):
raise ValueError(
msg.format(
rp=d_artifact.relative_path,
c=d_content.content.filename,
c=d_content.content.natural_key(),
rname=d_artifact.remote.name,
)
)
Expand Down

0 comments on commit 6e18f2e

Please sign in to comment.