Fix OOM error after uploading large chunked file

fixes: #2573
pulp · Apr 27, 2022 · ba7ab5e · ba7ab5e
1 parent 0888384
commit ba7ab5e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES/2573.bugfix b/CHANGES/2573.bugfix
@@ -0,0 +1 @@
+Fixed OOM error after uploading large chunked files.
diff --git a/pulpcore/app/files.py b/pulpcore/app/files.py
@@ -34,15 +34,16 @@ def from_file(cls, file):
         name = os.path.basename(file.name)
         instance = cls(name, "", file.size, "", "")
         instance.file = file
-        data = file.read()
+        # Default 1MB
+        while data := file.read(1048576):
+            for hasher in models.Artifact.DIGEST_FIELDS:
+                instance.hashers[hasher].update(data)
 
         # calling the method read() moves the file's pointer to the end of the file object,
         # thus, it is necessary to reset the file's pointer position back to 0 in case of
         # calling the method read() again from another place
         file.seek(0)
 
-        for hasher in models.Artifact.DIGEST_FIELDS:
-            instance.hashers[hasher].update(data)
         return instance