Delete associated files from the storage

closes #7316

CHANGES/7316.feature

@@ -0,0 +1 @@
+Added the django-cleanup handlers for removing files stored within FileField

CHANGES/plugin_api/7316.feature

@@ -0,0 +1,2 @@
+Enabled the automatic removal of files, which are stored in FileField, when a corresponding
+model's delete() method is invoked

pulpcore/app/models/content.py

@@ -95,17 +95,6 @@ def save(self, *args, **kwargs):
         finally:
             self.file.close()
 
-    def delete(self, *args, **kwargs):
-        """
-        Deletes Model and the file associated with the Model
-
-        Args:
-            args (list): list of positional arguments for Model.delete()
-            kwargs (dict): dictionary of keyword arguments to pass to Model.delete()
-        """
-        super().delete(*args, **kwargs)
-        self.file.delete(save=False)
-
 
 class Artifact(HandleTempFilesMixin, BaseModel):
     """

pulpcore/app/models/upload.py

@@ -46,17 +46,6 @@ def append(self, chunk, offset, sha256=None):
 
         self.chunks.create(offset=offset, size=len(chunk))
 
-    def delete(self, *args, **kwargs):
-        """
-        Deletes Upload model and the file associated with the model
-
-        Args:
-            args (list): list of positional arguments for Model.delete()
-            kwargs (dict): dictionary of keyword arguments to pass to Model.delete()
-        """
-        super().delete(*args, **kwargs)
-        self.file.delete(save=False)
-
 
 class UploadChunk(BaseModel):
     """

pulpcore/app/settings.py

@@ -65,6 +65,8 @@
     "rest_framework",
     # pulp core app
     "pulpcore.app",
+    # the cleanup config has to be placed last
+    "django_cleanup.apps.CleanupConfig",
 ]
 
 # Enumerate the installed Pulp plugins during the loading process for use in the status API

requirements.txt

@@ -4,6 +4,7 @@ aiofiles
 backoff
 Django~=2.2.14  # LTS version, switch only if we have a compelling reason to
 django-currentuser~=0.5.1
+django-cleanup~=5.0.0
 django-filter~=2.3.0
 django-guardian~=2.3.0
 django-import-export~=2.3.0