Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated (nested) api's to manipulate labels on objects #3332

Closed
mdellweg opened this issue Oct 19, 2022 · 1 comment · Fixed by #4344
Closed

Dedicated (nested) api's to manipulate labels on objects #3332

mdellweg opened this issue Oct 19, 2022 · 1 comment · Fixed by #4344
Assignees
Labels

Comments

@mdellweg
Copy link
Member

Currently you can only update the pulp_labels object as a whole. This can lead to all the common problems with concurrent updates.
Suggestion: Add a dedicated {pulp_obj_href}/labels/ endpoint to allow crud operations on individual labels.

@ggainey
Copy link
Contributor

ggainey commented Oct 25, 2022

discussion from openfloor:

ipanova
x9c4
: is the update call for labels is sync or async now?

x9c4@x9c4:x9c4.spdns.org
It's only accessible by updating the attached resource. And that may or may not be async.
also you need to set the dict of labels to be on an update call.

gerrod
so is this about updating an individual label?

x9c4@x9c4:x9c4.spdns.org
yes.

gerrod
accept, I'm pretty sure we store the labels individually in the database so this is a serializer/endpoint change

ggainey
^change^addition :)
works4me

x9c4@x9c4:x9c4.spdns.org
This is only meant as an additional (safer) way to access the labels.

@mdellweg mdellweg self-assigned this Aug 30, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 30, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 30, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 30, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 31, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 31, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Aug 31, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Sep 1, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Sep 1, 2023
mdellweg added a commit to mdellweg/pulpcore that referenced this issue Sep 1, 2023
mdellweg added a commit that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants