New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a plugin writer, I have to opt-out to having a "non-redirect" behavior in the content app #3459
Comments
@pulp/core FYI |
Clarification: implementing this requires more than just re-pushing the PR - it requires adding machinery to let plugins opt in/out of the behavior |
I do not understand the need to enable or disable the feature in the plugin's code. We decided to revert the commit because we had compatibility issues in pulp_container (#3434 (comment)) and pulp_python (#3456). The branch where the commit was merged had not been identified as a branch holding breaking changes. Is it acceptable to merge the very same commit with, for instance, a hook method that will enable plugin writers to create an additional wrap-around on top of the non-redirect workflow, if needed? This is what we were trying to add to pulp_container to fix the issues: pulp/pulp_container#1179. |
Is this classified as a duplicate of #3173 now? |
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459
This patch returns a 301 redirect when a requested path does not end in a / but should end in a /. Changes the order in which pulpcore-content looks for published artifacts The handler now looks for a published artifact before it tries to look for an index.html or listing the directory. fixes: pulp#3173 fixes: pulp#3459 Co-authored-by: bmbouter <bmbouter@gmail.com>
This is the API change required for #3173. |
With the pulpcore 3.22 release, we planned to make the "redirect to include a trailing slash" behavior a plugin opt-in feature. We couldn't make it opt-out because pulp_container breaks with this and pre-existing GA releases of pulp_container declare forward compatibility through pulpcore 3.24.
This issue tracks the change: With 3.25, have the "redirect to include a trailing slash" be a plugin opt-out feature and have it enabled by default.
The text was updated successfully, but these errors were encountered: