Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export.task prevents task purge to succeed #3530

Closed
mdellweg opened this issue Jan 27, 2023 · 3 comments · Fixed by #3709
Closed

export.task prevents task purge to succeed #3530

mdellweg opened this issue Jan 27, 2023 · 3 comments · Fixed by #3709
Assignees
@MichalPysik
Labels
Issue prio-list

Comments

@mdellweg
Copy link
Member

We probably want to classify the foreign key here
https://github.com/pulp/pulpcore/blob/main/pulpcore/app/models/exporter.py#L30
to be SET_NULL.
@ggainey
Copy link
Contributor

ggainey commented Jan 27, 2023

We should also need to teach task-purge to continue in the face of errors - just because one/several tasks can't be deleted, shouldn't fail the run. We don't know what models might do this exact thing in the future...

@dralley
Copy link
Contributor

dralley commented Jan 27, 2023

+1 to both

@MichalPysik MichalPysik self-assigned this Apr 4, 2023
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 4, 2023
@MichalPysik
Improved task purge, resolved purge vs export conflict
8d2043f 
When there was a completed export in the task list, task purge
would fail as the task could not be deleted because of a dependency
to a linked object. This issue has been resolved.

When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
@MichalPysik MichalPysik mentioned this issue Apr 4, 2023
Merged
@MichalPysik
Copy link
Member

#3708
@mdellweg @ggainey @dkliban

MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 4, 2023
@MichalPysik
Improved task purge, resolved purge vs export conflict
2a33ee0 
When there was a completed export in the task list, task purge
would fail as the task could not be deleted because of a dependency
to a linked object. This issue has been resolved.

When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 4, 2023
@MichalPysik
Improved task purge, resolved purge vs export conflict
1e94764 
When there was a completed export in the task list, task purge
would fail as the task could not be deleted because of a dependency
to a linked object. This issue has been resolved.

When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 5, 2023
@MichalPysik
Resolved purge vs export conflict
5a07f24 
When there was a completed export in the task list, task purge
would fail as the task could not be deleted because of a dependency
to a linked object. This issue has been resolved.

fixes: pulp#3530
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 19, 2023
@MichalPysik
Reworked the task purge feature
852071f 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
@MichalPysik MichalPysik mentioned this issue Apr 19, 2023
Merged
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 25, 2023
@MichalPysik
Reworked the task purge feature
7173ce1 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
MichalPysik added a commit to MichalPysik/pulpcore that referenced this issue Apr 25, 2023
@MichalPysik
Reworked the task purge feature
85f86bb 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: pulp#3530
mdellweg pushed a commit that referenced this issue Apr 26, 2023
@MichalPysik @mdellweg
Reworked the task purge feature
eb1117e 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: #3530
@patchback patchback bot mentioned this issue Apr 26, 2023
Merged
patchback bot pushed a commit that referenced this issue Apr 26, 2023
@MichalPysik @patchback
Reworked the task purge feature
433ed10 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: #3530
(cherry picked from commit eb1117e)
ipanova pushed a commit that referenced this issue Apr 26, 2023
@MichalPysik @ipanova
Reworked the task purge feature
3511b37 
When an object could not be deleted, the purge task would fail.
This has been reworked  so that the purge continues to delete
other tasks and informs the user about tasks that could not be
deleted.

fixes: #3530
(cherry picked from commit eb1117e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichalPysik MichalPysik

Labels
Issue prio-list
Projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reworked the task purge feature MichalPysik/pulpcore
5 participants
@dkliban @dralley @ggainey @mdellweg @MichalPysik