Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open Telemetry support to the pulp-content app #3829

Closed
Tracked by #4604
decko opened this issue May 15, 2023 · 0 comments · Fixed by #4745
Closed
Tracked by #4604

Add Open Telemetry support to the pulp-content app #3829

decko opened this issue May 15, 2023 · 0 comments · Fixed by #4745
Assignees
@lubosmj
Labels
Feature services

Comments

@decko
Copy link
Member

decko commented May 15, 2023 •
edited by bmbouter

Feature

Adds open telemetry metrics support to the pulp-content app. For example, it should report response codes and latency of all requests the content app handles.

Implementation

Option A: Use the aiohttp-server telemetry support from upstream

This would include use picking up the dependency opentelemetry-instrumentation-aiohttp-server and enabling it in pulpcore like this. Also we would add some tests for it.

To pursue this option the upstream PR needs to be merged and released to PyPI.

Option B: Vendor the upstream not-merged-not-released aiohttp-server telemetry support

This involves us vendoring the unmerged or unreleased upstream code temporarily into Pulp. Since we're bringing the code it doesn't involve us picking up a dependency. It would still need to be enabled in pulpcore like this. We would still need to add tests for it just like Option A.

This option is a temporary option. Option A is really the only long-term option.
@decko decko mentioned this issue May 15, 2023
Closed
decko added a commit that referenced this issue May 15, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
dc1dd41 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 15, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
113bf43 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 15, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
4ca6a62 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
66b99af 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
25cb16f 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
0c25639 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
50ea8ac 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
0ee2cbc 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
9d23ce9 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 16, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
375a081 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 17, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
01dc215 
…dleware list

Closes #3829
decko added a commit that referenced this issue May 19, 2023
@decko
Vendor the aiohttp instrumentation code and add it to the aiohttp mid…
af9191e 
…dleware list

Closes #3829
@bmbouter bmbouter changed the title Add the OpenTelemetry Aiohttp-server instrumentation as a vendor library Add Open Telemetry support to the pulp-content app Oct 20, 2023
This was referenced Oct 20, 2023
Open
Open
@lubosmj lubosmj self-assigned this Nov 13, 2023
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Intrument content-app
8fc7be0 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
@lubosmj lubosmj mentioned this issue Nov 20, 2023
Merged
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Instrument content-app
b69216f 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
cb5a6b1 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
81ae456 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
184c8f2 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
aa11b30 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
0c798c2 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 20, 2023
@lubosmj
Add instrumentation to content-app
08974d8 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
e4f5479 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
7c1508f 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
4411a6f 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
af2197f 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
65e1b08 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
d5fe356 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
585bb08 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
6f14098 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
0eb374e 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
b630e9a 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
4b3d69e 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
90628ae 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 21, 2023
@lubosmj
Add instrumentation to content-app
42a399b 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 22, 2023
@lubosmj
Add instrumentation to content-app
8de03eb 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 22, 2023
@lubosmj
Add instrumentation to content-app
72809f3 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 22, 2023
@lubosmj
Add instrumentation to content-app
40d40f8 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 28, 2023
@lubosmj
Add instrumentation to content-app
a6a864d 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Nov 28, 2023
@lubosmj
Add instrumentation to content-app
1332cff 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes pulp#3829
lubosmj added a commit that referenced this issue Nov 28, 2023
@lubosmj
Add instrumentation to content-app
763010e 
The instrumentation code from the upstream PR was brought down to pulpcore
because of pypi/support#3353.

closes #3829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubosmj lubosmj

Labels
Feature services
Projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
3 participants
@decko @bmbouter @lubosmj