New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitor_task_group() fixture can get stuck in an infinite wait #3923
Comments
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Jun 14, 2023
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Jul 11, 2023
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Jul 12, 2023
ggainey
added a commit
that referenced
this issue
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
main
Describe the bug
If a task-group fails catastrophically before it can dispatch any tasks, then the monitor_task_group() will enter the "wait for completion" loop and never come out.
task_group.all_tasks_dispatched
starts as False, and is never set to True, so this check:https://github.com/pulp/pulpcore/blob/main/pulpcore/tests/functional/__init__.py#L817
is always True.
To Reproduce
Steps to reproduce the behavior:
This PR pulp/pulp_file#969 puts the lowerbounds CI test into an infinite wait, because the fix it's testing for isn't backported to core/3.23, and fails as described above, which causes the loop to spin forever, which causes lowerbounds to never complete.
Expected behavior
monitor_task_group() needs to recognize catastrophic-failure a little better.
The text was updated successfully, but these errors were encountered: