Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor_task_group() fixture can get stuck in an infinite wait #3923

Closed
ggainey opened this issue Jun 14, 2023 · 0 comments · Fixed by #3924
Closed

monitor_task_group() fixture can get stuck in an infinite wait #3923

ggainey opened this issue Jun 14, 2023 · 0 comments · Fixed by #3924
Assignees

Comments

@ggainey
Copy link
Contributor

ggainey commented Jun 14, 2023

Version
main

Describe the bug
If a task-group fails catastrophically before it can dispatch any tasks, then the monitor_task_group() will enter the "wait for completion" loop and never come out. task_group.all_tasks_dispatched starts as False, and is never set to True, so this check:

https://github.com/pulp/pulpcore/blob/main/pulpcore/tests/functional/__init__.py#L817

is always True.

To Reproduce
Steps to reproduce the behavior:

This PR pulp/pulp_file#969 puts the lowerbounds CI test into an infinite wait, because the fix it's testing for isn't backported to core/3.23, and fails as described above, which causes the loop to spin forever, which causes lowerbounds to never complete.

Expected behavior
monitor_task_group() needs to recognize catastrophic-failure a little better.

@ggainey ggainey self-assigned this Jun 14, 2023
ggainey added a commit to ggainey/pulpcore that referenced this issue Jun 14, 2023
ggainey added a commit to ggainey/pulpcore that referenced this issue Jul 11, 2023
ggainey added a commit to ggainey/pulpcore that referenced this issue Jul 12, 2023
patchback bot pushed a commit that referenced this issue Jul 27, 2023
patchback bot pushed a commit that referenced this issue Jul 27, 2023
patchback bot pushed a commit that referenced this issue Jul 27, 2023
dkliban pushed a commit that referenced this issue Jul 27, 2023
dkliban pushed a commit that referenced this issue Jul 27, 2023
dkliban pushed a commit that referenced this issue Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants