New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content-app doesn't respect response-headers specified by plugins #4028
Labels
Comments
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Aug 3, 2023
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Aug 3, 2023
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Aug 4, 2023
ggainey
added a commit
to ggainey/pulpcore
that referenced
this issue
Aug 5, 2023
ggainey
added a commit
that referenced
this issue
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
3.28
Describe the bug
core/3.28 added Distribution.content_headers_for() to allow plugins to specifiy response-headers. When using non-FileStorage backends, these headers are ignored.
pulp_rpm PR pulp/pulp_rpm#3193 , for example, fails on azure and S3 because the cache-disposition header isn't ending up in the response.
To Reproduce
Expected behavior
headers added by a plugin should be made available in the response
Additional context
With azure and google, looks like we can just feed the headers into response-parameters. S3 may need specific code.
The text was updated successfully, but these errors were encountered: