Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair API should be tolerant of any failure during the repair process #4111

Closed
ipanova opened this issue Jul 21, 2023 · 1 comment · Fixed by #4112
Closed

Repair API should be tolerant of any failure during the repair process #4111

ipanova opened this issue Jul 21, 2023 · 1 comment · Fixed by #4112
Assignees
@ipanova
Labels
Issue prio-list Triage-Needed

Comments

@ipanova
Copy link
Member

ipanova commented Jul 21, 2023 •
edited

Version
main and older

Describe the bug
We have made repair api tolerant to a 404 error but that is not the only error that someone can receive.

If remote is associated with a proxy and that proxy is limiting connections or misconfigured someway, Then TimeoutException would be a common thing to occur as well.
If Firewall is not properly configured that may even result in "Connection Reset".

No matter what the failure is, The Repair API, should not halt but continue processing rest of the units that it has identified as corrupted or missing.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
https://bugzilla.redhat.com/show_bug.cgi?id=2173692#c13
#3611 cope with 404
@vijaysawant
Copy link

I would request you to look at 6.13.3 Failed QA BZ's traceback which is here https://bugzilla.redhat.com/show_bug.cgi?id=2218980#c2 and we need to consider "DigestValidationError" error as well in the fix of upstream issue request #4111, as this checksum verification is another issue CU are facing.

ipanova added a commit to ipanova/pulpcore that referenced this issue Jul 21, 2023
@ipanova
Taught repair task to be tolerant in the face of any failure during t…
81ad3c8 
…he repair process.

closes pulp#4111
@ipanova ipanova self-assigned this Jul 21, 2023
ipanova added a commit to ipanova/pulpcore that referenced this issue Jul 21, 2023
@ipanova
Taught repair task to be tolerant in the face of any failure during t…
51963f9 
…he repair process.

closes pulp#4111
ipanova added a commit to ipanova/pulpcore that referenced this issue Jul 21, 2023
@ipanova
Taught repair task to be tolerant in the face of any artifact downloa…
ca86ff5 
…d failure.

closes pulp#4111
@ipanova ipanova mentioned this issue Jul 21, 2023
Merged
ipanova added a commit to ipanova/pulpcore that referenced this issue Jul 21, 2023
@ipanova
Taught repair task to be tolerant in the face of any artifact downloa…
a135aa8 
…d failure.

closes pulp#4111
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
4310ea0 
…d failure.

closes #4111
patchback bot pushed a commit that referenced this issue Jul 21, 2023
@ipanova @patchback
Taught repair task to be tolerant in the face of any artifact downloa…
26869fb 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
@patchback patchback bot mentioned this issue Jul 21, 2023
Merged
patchback bot pushed a commit that referenced this issue Jul 21, 2023
@ipanova @patchback
Taught repair task to be tolerant in the face of any artifact downloa…
dda35bf 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
@patchback patchback bot mentioned this issue Jul 21, 2023
Merged
patchback bot pushed a commit that referenced this issue Jul 21, 2023
@ipanova @patchback
Taught repair task to be tolerant in the face of any artifact downloa…
ef2ad64 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
@patchback patchback bot mentioned this issue Jul 21, 2023
Merged
patchback bot pushed a commit that referenced this issue Jul 21, 2023
@ipanova @patchback
Taught repair task to be tolerant in the face of any artifact downloa…
b212be6 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
@patchback patchback bot mentioned this issue Jul 21, 2023
Merged
patchback bot pushed a commit that referenced this issue Jul 21, 2023
@ipanova @patchback
Taught repair task to be tolerant in the face of any artifact downloa…
20af812 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
@patchback patchback bot mentioned this issue Jul 21, 2023
Merged
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
700b0f3 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
3ab04e0 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
5d111c6 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
a9f31e7 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
dralley pushed a commit that referenced this issue Jul 21, 2023
@ipanova @dralley
Taught repair task to be tolerant in the face of any artifact downloa…
781f36d 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
mdellweg pushed a commit to mdellweg/pulpcore that referenced this issue Jan 18, 2024
@ipanova @mdellweg
Taught repair task to be tolerant in the face of any artifact downloa…
01dddfd 
…d failure.

closes pulp#4111

(cherry picked from commit 4310ea0)
mdellweg pushed a commit that referenced this issue Jan 18, 2024
@ipanova @mdellweg
Taught repair task to be tolerant in the face of any artifact downloa…
f908301 
…d failure.

closes #4111

(cherry picked from commit 4310ea0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipanova ipanova

Labels
Issue prio-list Triage-Needed
Projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Taught repair task to be tolerant in the face of any artifact downloa… ipanova/pulpcore
2 participants
@ipanova @vijaysawant