Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to use default gunicorn features, like config files #4917

Closed
sdherr opened this issue Jan 10, 2024 · 0 comments · Fixed by #4918
Closed

Impossible to use default gunicorn features, like config files #4917

sdherr opened this issue Jan 10, 2024 · 0 comments · Fixed by #4918

Comments

@sdherr
Copy link
Contributor

sdherr commented Jan 10, 2024

The current way that you create the Gunicorn applications in app/entrypoint.py and content/entrypoint.py only allow you to pass in a small set of pre-defined click options, and short-circuits the normal Gunicorn process of loading other options from a config file, among many other unavailable options.

By default Gunicorn would normally load a "gunicorn.conf.py" file in the same cwd as the process if it exists. If we re-enable that then any Gunicorn options or other complex settings you didn't want to directly support could be set there.

(In particular I have a desire to filter health-check pings out of the access logs, which you can do with default Gunicorn by adding a logging.Filter to server.log.access_log in an on_startup hook. Something I wouldn't expect you to directly support, but can be done easily by adding a Gunicorn config file.)

sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 10, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 10, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 10, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 11, 2024
sdherr added a commit to sdherr/pulpcore that referenced this issue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant