Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task cleanup must not delete content nor artifacts #5363

Closed
mdellweg opened this issue May 13, 2024 · 0 comments · Fixed by #5365
Closed

Task cleanup must not delete content nor artifacts #5363

mdellweg opened this issue May 13, 2024 · 0 comments · Fixed by #5365
Labels
Issue Triage-Needed

Comments

@mdellweg
Copy link
Member

mdellweg commented May 13, 2024 •
edited

Deleting content or artifacts outside of orphan cleanup is breaking the rules.
And no, we cannot get away with that.
mdellweg added a commit to mdellweg/pulpcore that referenced this issue May 13, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
37090fb 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes pulp#5363
@mdellweg mdellweg mentioned this issue May 13, 2024
Merged
mdellweg added a commit to mdellweg/pulpcore that referenced this issue May 13, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
4e3ed6b 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes pulp#5363
mdellweg added a commit to mdellweg/pulpcore that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
3b8b14f 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes pulp#5363
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
fb47f3c 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363
patchback bot pushed a commit that referenced this issue May 14, 2024
@mdellweg @patchback
Stop task cleanup to delete Contents and Artifacts
3fb60d9 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
@patchback patchback bot mentioned this issue May 14, 2024
Merged
patchback bot pushed a commit that referenced this issue May 14, 2024
@mdellweg @patchback
Stop task cleanup to delete Contents and Artifacts
20b9b03 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
@patchback patchback bot mentioned this issue May 14, 2024
Merged
patchback bot pushed a commit that referenced this issue May 14, 2024
@mdellweg @patchback
Stop task cleanup to delete Contents and Artifacts
3454e54 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
@patchback patchback bot mentioned this issue May 14, 2024
Merged
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
ff7ecfc 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
5f75591 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
5dea534 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
mdellweg added a commit to mdellweg/pulpcore that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
b4de001 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes pulp#5363

(cherry picked from commit fb47f3c)
@mdellweg mdellweg mentioned this issue May 14, 2024
Merged
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
ec26ffe 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
patchback bot pushed a commit that referenced this issue May 14, 2024
@mdellweg @patchback
Stop task cleanup to delete Contents and Artifacts
e1b17aa 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
(cherry picked from commit ec26ffe)
@patchback patchback bot mentioned this issue May 14, 2024
Merged
mdellweg added a commit to mdellweg/pulpcore that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
e449ca9 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes pulp#5363

(cherry picked from commit fb47f3c)
(cherry picked from commit ec26ffe)
@mdellweg mdellweg mentioned this issue May 14, 2024
Merged
lubosmj pushed a commit that referenced this issue May 14, 2024
@mdellweg @lubosmj
Stop task cleanup to delete Contents and Artifacts
0340a3f 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
(cherry picked from commit ec26ffe)
mdellweg added a commit that referenced this issue May 14, 2024
@mdellweg
Stop task cleanup to delete Contents and Artifacts
7b0d7b5 
These shared objects that may not even have been created by that task
must only ever be deleted inside of orphan cleanup. That's the rule.

fixes #5363

(cherry picked from commit fb47f3c)
(cherry picked from commit ec26ffe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop task cleanup to delete Contents and Artifacts mdellweg/pulpcore
1 participant
@mdellweg