-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to save Task Diagnostic data #5422
Comments
Time for dogfooding: Let's put any type of report in artifacts. |
Maybe use pulp_file to save this data. |
Which things we're getting from the diagnostics? Can we get the same information using other ways, like container metrics, or OTEL? |
Saving the data as a pulp_file artifact I think is a great idea. That would be even easier for us to pull the data back out then. So would that be:
What do you think? |
Adding a file to that repository requires a task. That may create an infinite loop. |
I see the value of storing the output files solely in artifacts because those could be saved without depending on the tasking system. Also they will automatically be picked up by the orphan clean up. |
Saving them as an artifact sounds even better for all the reasons mentioned. Also it would avoid the admin even having to create a dedicated pulp_file repo. When a task runs, how can I know how to fetch that saved artifact? If that's easy then I'm +1 on this. |
I thought about this some more and what would be nice is if the Task got a |
We should be able to at least to log the href of the created artifact whenever task_diagnostics is on. |
Logging would work. Having it on the task is more beneficial for our use for a few reasons:
|
@bmbouter I agree that having it directly on the task is more transparent, just we never placed artifacts nor content as created_resource, only those resources that require locking, like repos, remotes, distributions, etc |
@ipanova I agree and I'm also a little uneasy setting that precedent here. Is there another option to have that info added to the task somehow? |
We discussed at pulpcore meeting today. Here's my summary of what I think the plan is. Let's implement this setting to save the bare Artifact (not a file content unit, not in a file repo) and just have it log for now. We can look at improving the usability later as a separate issue. This avoids us having to set the precident adding an Artifact to the created_resources data of a task. @pulp/core is this right? |
When using a k8s hosted version of Pulp, we can enable
TASK_DIAGNOSTICS
, but getting the saved/var/tmp/pulp/<task_UUID>/
is really difficult. We greatly need this data.What would be easy in this type of deployment would be for the data to be saved to an S3 bucket somehow.
The text was updated successfully, but these errors were encountered: