Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fields controlling connection-timeouts to Remote. #1026

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Added fields controlling connection-timeouts to Remote. #1026

merged 1 commit into from
Dec 3, 2020

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Nov 13, 2020

closes #7201

@pulpbot
Copy link
Member

pulpbot commented Nov 13, 2020

Attached issue: https://pulp.plan.io/issues/7201

bmbouter
bmbouter reviewed Nov 16, 2020
View reviewed changes
docs/settings.rst Outdated Show resolved Hide resolved
bmbouter
bmbouter reviewed Nov 16, 2020
View reviewed changes
CHANGES/7201.feature Outdated Show resolved Hide resolved
bmbouter
bmbouter requested changes Nov 16, 2020
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite my variety of comments, this PR is bigtime going in the right direction.

@ggainey ggainey force-pushed the 7201_timeouts branch 2 times, most recently from 59a89cc to 1f10c94 Compare December 2, 2020 22:14
bmbouter
bmbouter approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thank you so much @ggainey !

goosemania
goosemania approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daviddavis daviddavis merged commit 05faf9f into pulp:master Dec 3, 2020
@ggainey ggainey deleted the 7201_timeouts branch April 27, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg left review comments

@bmbouter bmbouter bmbouter approved these changes

@goosemania goosemania goosemania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ggainey @pulpbot @bmbouter @goosemania @mdellweg @daviddavis