Fix import/export bug when sha384 or sha512 are null #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue7836
branch
from
fb9e6ad
to
eb0514e
Compare
|
Attached issue: https://pulp.plan.io/issues/7836 |
daviddavis
force-pushed
the
issue7836
branch
2 times, most recently
from
ea18d8d
to
d0d47c7
Compare
ipanova
approved these changes
Dec 10, 2020
mdellweg
reviewed
Dec 10, 2020
pulpcore/app/modelresource.py
Outdated
| if row["sha384"] == "": | ||
| row["sha384"] = None | ||
| if row["sha512"] == "": | ||
| row["sha512"] = None |
There was a problem hiding this comment.
Should we not do it for all digests for consistency?
There was a problem hiding this comment.
It's not necessary since the other checksums aren't unique. But we could do it for other checksums--I don't think it would hurt.
There was a problem hiding this comment.
It feels weird to do something with only a subset of those otherwise very symmetric digests.
daviddavis
force-pushed
the
issue7836
branch
from
d0d47c7
to
a6dcb44
Compare
mdellweg
approved these changes
Dec 10, 2020
pulpcore/app/modelresource.py
Outdated
|
|
||
| def before_import_row(self, row, **kwargs): | ||
| """ | ||
| Sets sha384 and sha512 to None if they are blank strings. |
There was a problem hiding this comment.
Suggested change
| Sets sha384 and sha512 to None if they are blank strings. | |
| Sets digests to None if they are blank strings. |
daviddavis
force-pushed
the
issue7836
branch
from
a6dcb44
to
d3aa9d7
Compare
daviddavis
force-pushed
the
issue7836
branch
from
d3aa9d7
to
66e29fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7836
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html