Fix another scenario where canceled tasks could be marked failed #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't be merged until rq/rq#1394 is |
|
Attached issue: https://pulp.plan.io/issues/8143 |
dralley
force-pushed
the
tasking-failure
branch
from
5b78ecb
to
664dcec
Compare
daviddavis
approved these changes
Mar 31, 2021
|
@daviddavis Yes, it's the same issue as the one you filed. I've marked mine as duplicate and changed all the references to your older one since it's more specific. @bmbouter @daviddavis I need both of you to re-review. Unfortunately during the RQ PR review process some of the details of the implementation changed which broke this patch, so I had to re-write it. It should work now however. |
daviddavis
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8143
https://pulp.plan.io/issues/8143