Add forbidden checksum checks to Artifact and RemoteArtifact #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8323 |
daviddavis
force-pushed
the
issue8323
branch
4 times, most recently
from
12e7fa3
to
06ed9bd
Compare
daviddavis
force-pushed
the
issue8323
branch
3 times, most recently
from
d19d5d5
to
7796792
Compare
daviddavis
changed the title
daviddavis
commented
Mar 2, 2021
| _("Checksum algorithm {} is forbidden for this Pulp instance.").format(attrname) | ||
| ) | ||
| else: | ||
| super(DigestModel, self).__setattr__(attrname, val) |
There was a problem hiding this comment.
The stages code instantiates Artifacts and RemoteArtifacts but then calls bulk_get_or_create() so a before_save isn't sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8323
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html