Deprecate WorkingDirectory #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
deprecate_working_directory
branch
2 times, most recently
from
3136867
to
0df6a9b
Compare
|
Attached issue: https://pulp.plan.io/issues/8231 |
dralley
reviewed
Mar 3, 2021
| directory. Those will automatically be cleaned up once the task is finished. | ||
|
|
||
| If a task needs to create more temporary directories, it is encouraged to use | ||
| ``tempfile.TemporaryDirectory(dir=".")`` from the python stdandard library to place them in the |
dralley
reviewed
Mar 3, 2021
| If a task needs to create more temporary directories, it is encouraged to use | ||
| ``tempfile.TemporaryDirectory(dir=".")`` from the python stdandard library to place them in the | ||
| tasks working directory. This is however only necessary, if the amount of temporarily saved data is | ||
| too much to wait for the automatic cleanup at the end of the task processing. |
There was a problem hiding this comment.
Or if you want to avoid file name conflicts.
mdellweg
force-pushed
the
deprecate_working_directory
branch
from
0df6a9b
to
d26e040
Compare
dralley
approved these changes
Mar 4, 2021
goosemania
reviewed
Mar 4, 2021
| **Worker and Tasks Directories** | ||
|
|
||
| In pulp each worker is assigned a unique working directory living in ``/var/lib/pulp/tmp/``, and | ||
| each started task will have its own clean temporary subdirectory therin as its current working |
goosemania
reviewed
Mar 4, 2021
| @@ -41,6 +41,6 @@ def get_policy_statements(self, request, view): | |||
| warnings.warn( | |||
| "Addressing AccessPolicy via the viewset's classname is deprecated" | |||
| "and will be removed in pulpcore==3.10; use the viewset's urlpattern().", | |||
| warnings.DeprecationWarning, | |||
| DeprecationWarning, | |||
There was a problem hiding this comment.
Should this warning be removed completely? It refers to 3.10.
It's not a part of the scope of this PR but since you are already doing some cleanup here :)
There was a problem hiding this comment.
Yes, we are already late here...
goosemania
reviewed
Mar 4, 2021
| @@ -29,7 +29,7 @@ def get_plugin_storage_path(plugin_app_label): | |||
| """ | |||
| warnings.warn( | |||
| "get_plugin_storage_path() is deprecated and will be removed in pulpcore==3.11.", | |||
| warnings.DeprecationWarning, | |||
| DeprecationWarning, | |||
There was a problem hiding this comment.
We should remove this deprecation as well, I wonder if the get_plugin_storage_path is removed or of there is a task for it
There was a problem hiding this comment.
I'll handle this one separately, FYI
mdellweg
force-pushed
the
deprecate_working_directory
branch
from
d26e040
to
d35d977
Compare
|
This issue is in the 3.12 milestone.Should we decide to merge it now please update the milestone accordingly. |
Additionally document the use of tempfile.TemporaryDirectory. fixes #8231 https://pulp.plan.io/issues/8231
mdellweg
force-pushed
the
deprecate_working_directory
branch
from
d35d977
to
f6db3b2
Compare
|
Removing is scheduled for 3.12 https://pulp.plan.io/issues/8354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally document the use of tempfile.TemporaryDirectory.
fixes #8231
https://pulp.plan.io/issues/8231