Make sensitive Remote fields write_only #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8202 |
|
I'm tempted to remove the tests from this PR since they are testing functionality in DRF and not pulpcore. |
|
The tests do mostly test DRF, but they implicitly test that Pulp is configuring |
bmbouter
reviewed
Mar 3, 2021
CHANGES/8202.removal
Outdated
| @@ -0,0 +1,2 @@ | |||
| Removed sensitive fields username, password, and client key from Remote responses. These fields can | |||
There was a problem hiding this comment.
Can we escape these?
Suggested change
| Removed sensitive fields username, password, and client key from Remote responses. These fields can | |
| Removed sensitive fields ``username``, ``password``, and ``client_key`` from Remote responses. These fields can |
fixes #8202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8202
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html