-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact checksums report #1173
Conversation
Attached issue: https://pulp.plan.io/issues/7986 |
Looking good. Will test it out later today. |
ee17438
to
3f766ac
Compare
3f766ac
to
c2a77cf
Compare
It looks like this is missing the
Bonus points if you write some unit tests for this method. |
c2a77cf
to
55acb15
Compare
55acb15
to
f90d834
Compare
f90d834
to
b91d58b
Compare
I did some testing and it seems to report correct thing. |
b91d58b
to
31338a6
Compare
cb51f9d
to
a3aff8d
Compare
a3aff8d
to
3a3d25c
Compare
3a3d25c
to
beda17c
Compare
|
||
Returns None | ||
""" | ||
for repo_version in repo_versions.iterator(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this produces wrong url. you need to call cast() on the repo and also add the versions
part to the url
Affected repository versions with present content:
/repositories/core/repository/58c1c1a0-4b6a-4140-a959-4bbbe81245aa/1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I think the correct thing to use would have been repository.pulp_type
rather than repository.get_pulp_type()
.
I think that should make casting unnecessary. +1 to versions at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dralley i can confirm repository.pulp_type works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used .pulp_type
instead casting.
86e0ac9
to
9880caf
Compare
reports local and remote artifacts with forbidden checksum type. re #7986 https://pulp.plan.io/issues/7986
9880caf
to
a8e2f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pulpcore-manager handle-artifact-checksums --report
reports local and remote artifacts with forbidden checksum type and approx size of it.re #7986
https://pulp.plan.io/issues/7986