Removed addressing AccessPolicy via the viewset's classname. #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8397 Attached issue: https://pulp.plan.io/issues/8395 |
mdellweg
reviewed
Mar 12, 2021
pulpcore/app/access_policy.py
Outdated
| return access_policy_obj.statements | ||
| return access_policy_obj.statements | ||
| except AccessPolicyModel.DoesNotExist: | ||
| return [] |
There was a problem hiding this comment.
BTW, i just realized, that the docstring of this function is lying.
mdellweg
reviewed
Mar 12, 2021
| @@ -23,7 +21,7 @@ def get_policy_statements(self, request, view): | |||
| The `pulpcore.plugin.models.AccessPolicy` instance is looked up by the `viewset_name` | |||
| attribute using:: | |||
|
|
|||
| AccessPolicyModel.objects.get(viewset_name=view.__model__.__name__) | |||
| AccessPolicyModel.objects.get(viewset_name=get_view_urlpattern(view)) | |||
closes #8397 closes #8395
mdellweg
approved these changes
Mar 12, 2021
goosemania
reviewed
Mar 15, 2021
| @@ -0,0 +1 @@ | |||
| It is not longer possible to address AccessPolicy via the viewset's classname. Viewset's urlpattern should be used instead. | |||
There was a problem hiding this comment.
Does it make sense to mention that it's deprecated, so it doesn't look scary, as we just removed it?
There was a problem hiding this comment.
up to you, I do not need to re-review
goosemania
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8397
closes #8395
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html