Don't check RemoteArtifact by artifact check #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check RemoteArtifact by artifact check in stages. closes: #8445 https://pulp.plan.io/issues/8445
|
Attached issue: https://pulp.plan.io/issues/8445 |
|
I'd like to see @bmbouter review on this one. |
bmbouter
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
I hand tested this against the reproducer without this patch and it reproduced the problem. I tested it with this patch and it resolved the problem.
Additionally, in reading the code I believe it's what should be done.
Thanks @pavelpicka ! 👍
daviddavis
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't check RemoteArtifact by artifact check in stages.
closes: #8445
https://pulp.plan.io/issues/8445