Universal content list properly excludes PublishedMetadata #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8447 |
mdellweg
approved these changes
Mar 31, 2021
CHANGES/8447.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Publications that create PublishedMetadata no longer break `/pulp/api/v3/content/` | |||
There was a problem hiding this comment.
We agreed, that this changelog should describe what changed in past tense. However i have no real suggestion of the top of my head.
Suggested change
| Publications that create PublishedMetadata no longer break `/pulp/api/v3/content/` | |
| Fixed a bug where the existence of PublishedMetadata broke `/pulp/api/v3/content/` by excluding them. |
I guess, even if it were able to show them it'd be considered a bug, because PublishedMetadata is not user facing.
There was a problem hiding this comment.
I would probably just keep it simple:
Suggested change
| Publications that create PublishedMetadata no longer break `/pulp/api/v3/content/` | |
| Fixed ``LookupError`` when hitting ``/pulp/api/v3/content/`` with published content. |
There was a problem hiding this comment.
I prefer
Fixed a bug where the existence of PublishedMetadata caused ``LookupError
when querying/pulp/api/v3/content/`
daviddavis
approved these changes
Mar 31, 2021
dralley
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8447
https://pulp.plan.io/issues/8447
Not sure how to add tests for this since I don't think pulp_file publications will trigger it.
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html