Adds new dispatch call and deprecate the old one
#1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
commented
Apr 1, 2021
pulpcore/tasking/tasks.py
Outdated
| @@ -176,6 +177,21 @@ def enqueue_with_reservation( | |||
| Raises: | |||
| ValueError: When `resources` is an unsupported type. | |||
| """ | |||
| logging.warning( | |||
There was a problem hiding this comment.
This needs to be refactored to use the facilities here: #1225
bmbouter
force-pushed
the
add-new-dispatch-interface
branch
from
a502591
to
e7e9533
Compare
|
Attached issue: https://pulp.plan.io/issues/8496 |
bmbouter
force-pushed
the
add-new-dispatch-interface
branch
from
e7e9533
to
d106f83
Compare
dralley
approved these changes
Apr 1, 2021
bmbouter
force-pushed
the
add-new-dispatch-interface
branch
from
d106f83
to
4237b9d
Compare
dralley
reviewed
Apr 2, 2021
| resp = {"task": reverse("tasks-detail", args=[result.id], request=None)} | ||
| try: | ||
| pk = task.id | ||
| except AttributeError: |
There was a problem hiding this comment.
Ah, I see. Just put an inline comment about which maps to which (RQ vs Task). PK makes it clear-ish but it would still be helpful.
There was a problem hiding this comment.
The new dispatch interface returns a Task, but the old enqueue_with_reservation returns a RQ.job. Both return types end up getting passed into OperationPostponedResponse (see L#21 docstring). If id is present it's the RQ.job style, otherwise it's the `Task. Maybe I should put a comment on this in the code?
dralley
approved these changes
Apr 2, 2021
This adds a new `pulpcore.plugin.tasking.dispatch` interface which will replace the `pulpcore.plugin.tasking.enqueue_with_reservation` interface. This also deprecates the `pulpcore.plugin.tasking.enqueue_with_reservation` and causes it to emit warnings if used. Additionally the `pulpcore.plugin.viewsets.OperationPostponedResponse` has been ported to support both the `dispatch` and `enqueue_with_reservation` interfaces. closes #8496
bmbouter
force-pushed
the
add-new-dispatch-interface
branch
from
4237b9d
to
1fd7a9a
Compare
mdellweg
reviewed
Apr 6, 2021
[noissue] Co-authored-by: Matthias Dellweg <2500@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
pulpcore.plugin.tasking.dispatchinterface which willreplace the
pulpcore.plugin.tasking.enqueue_with_reservationinterface. This also deprecates the
pulpcore.plugin.tasking.enqueue_with_reservationand causes it toemit warnings if used.
Additionally the
pulpcore.plugin.viewsets.OperationPostponedResponsehas been ported to support both the
dispatchandenqueue_with_reservationinterfaces.closes #8496