Add support for automatic publishing #1229

dralley · 2021-04-02T02:12:07Z

closes: #7626
https://pulp.plan.io/issues/7626

dralley · 2021-04-02T02:29:34Z

You'll notice that this implementation is a lot different (simpler) than it was before, and that I ditched PublishSettings objects entirely.

Basically, as I thought about it more and more, I talked myself out of the whole idea, despite being the one of the ones pushing for it initially. I went with autopublish + publish settings (flat, individual fields) on the repository instead.

There are many reasons why but the simplest is:

Most plugins either
- don't even do publications at all, and therefore have no need to care about publish settings
- only have one or two settings, which might even be the default 99.9% of the time, like "manifest" for the file plugin, or no publish time options at all like the python plugin

So adding this whole new thing in core, and trying to manage even more relationships, and making 75% of plugins more tricky to use for an architecture that would only benefit some very niche use cases (sharing publish settings) for maybe 1/3 of the plugins, just doesn't make a whole lot of sense to me anymore. The cure is worse than the disease I think.

There's other reasons too which I can explain on a call or something.

Required PR: pulp/pulpcore#1229 closes: #7469 https://pulp.plan.io/issues/7469

pulpbot · 2021-04-02T02:49:58Z

Attached issue: https://pulp.plan.io/issues/7626

Required PR: pulp/pulpcore#1229 closes: #7469 https://pulp.plan.io/issues/7469

Required PR: pulp/pulpcore#1229 [noissue]

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

functest_requirements.txt

mdellweg · 2021-04-06T08:44:16Z

pulpcore/app/migrations/0062_add_new_distribution_mastermodel.py

@@ -25,7 +25,7 @@ class Migration(migrations.Migration):
                ('content_guard', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='core.ContentGuard')),
                ('publication', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='core.Publication')),
                ('remote', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='core.Remote')),
-                ('repository', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='core.Repository')),
+                ('repository', models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, to='core.Repository', related_name='distributions')),


Not entirely sure, if this should be a new migration.

i believe this is an automatic one produced with 'makemigrations'

It is modifying a migration that is on master, but not yet released. I'm not saying we should not do this, however, just asking.

hmm i see what you're saying - i think in the past practice we'd just have a migration on top instead of modifying an unreleased one.

I can do that if there's a strong desire to. I just thought that since this work and Brian's is so closely linked, there's not a great need to create an entire new migration just for this one-line change that I probably should have asked for on his PR initially.

So, not a strong opinion, just convenience.

Not a strong opinion here.

pulpcore/app/models/repository.py

dralley · 2021-04-06T15:10:50Z

CHANGES/plugin_api/7626.feature

@@ -0,0 +1 @@
+Added a new callback method to `Repository` named `on_new_version()`, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.


@daviddavis How is this

Suggested change

Added a new callback method to `Repository` named `on_new_version()`, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.

Added a new callback method to ``Repository`` named ``on_new_version()``, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.

Required PR: pulp/pulp_file#492 closes: #7626 https://pulp.plan.io/issues/7626

Required PR: pulp/pulpcore#1229 [noissue]

dralley force-pushed the auto-publish-distribute branch from 65fdab8 to c90cf13 Compare April 2, 2021 02:12

dralley mentioned this pull request Apr 2, 2021

Add support for automatic publishing and distributing pulp/pulp_file#492

Merged

dralley added a commit to dralley/pulp_file that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

f95e3f0

Required PR: pulp/pulpcore#1229 closes: #7469 https://pulp.plan.io/issues/7469

dralley force-pushed the auto-publish-distribute branch from c90cf13 to 42b6bf0 Compare April 2, 2021 02:31

dralley added a commit to dralley/pulp_file that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

cb8db48

Required PR: pulp/pulpcore#1229 closes: #7469 https://pulp.plan.io/issues/7469

dralley added a commit to dralley/pulp_file that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

fe2a2c9

Required PR: pulp/pulpcore#1229 closes: #7469 https://pulp.plan.io/issues/7469

dralley force-pushed the auto-publish-distribute branch 2 times, most recently from 0da2d86 to 5f2779d Compare April 2, 2021 03:22

dralley added a commit to dralley/pulp_ansible that referenced this pull request Apr 2, 2021

Small changes to match current best practices

39939df

Required PR: pulp/pulpcore#1229 [noissue]

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

80cfa20

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

5029773

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

c393a64

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

9c6ee86

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

61401d2

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

dralley added a commit to dralley/pulp_rpm that referenced this pull request Apr 2, 2021

Add support for automatic publishing and distributing

38abc38

Required PR: pulp/pulpcore#1229 closes: #7622 https://pulp.plan.io/issues/7622

mdellweg reviewed Apr 6, 2021

View reviewed changes

daviddavis reviewed Apr 6, 2021

View reviewed changes

pulpcore/app/models/repository.py Show resolved Hide resolved

dralley force-pushed the auto-publish-distribute branch from 5f2779d to b689e0e Compare April 6, 2021 15:10

dralley commented Apr 6, 2021

View reviewed changes

dralley force-pushed the auto-publish-distribute branch from b689e0e to 23bb55c Compare April 6, 2021 15:42

daviddavis approved these changes Apr 6, 2021

View reviewed changes

Add support for automatic publishing

571655d

Required PR: pulp/pulp_file#492 closes: #7626 https://pulp.plan.io/issues/7626

dralley force-pushed the auto-publish-distribute branch from 23bb55c to 571655d Compare April 7, 2021 01:16

mdellweg approved these changes Apr 7, 2021

View reviewed changes

dralley merged commit 2679461 into pulp:master Apr 7, 2021

dralley deleted the auto-publish-distribute branch April 7, 2021 13:20

dralley added a commit to dralley/pulp_ansible that referenced this pull request Apr 19, 2021

Small changes to match current best practices

a1998b2

Required PR: pulp/pulpcore#1229 [noissue]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for automatic publishing #1229

Add support for automatic publishing #1229

dralley commented Apr 2, 2021

dralley commented Apr 2, 2021 •

edited

Loading

pulpbot commented Apr 2, 2021

mdellweg Apr 6, 2021

ipanova Apr 6, 2021

mdellweg Apr 6, 2021

ipanova Apr 6, 2021

dralley Apr 6, 2021

mdellweg Apr 6, 2021

dralley Apr 6, 2021

daviddavis Apr 6, 2021

		@@ -0,0 +1 @@
		Added a new callback method to `Repository` named `on_new_version()`, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.

	Added a new callback method to `Repository` named `on_new_version()`, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.
	Added a new callback method to ``Repository`` named ``on_new_version()``, which runs when a new repository version has been created. This can be used for e.g. automatically publishing or distributing a new repository version after it has been created.

Add support for automatic publishing #1229

Add support for automatic publishing #1229

Conversation

dralley commented Apr 2, 2021

dralley commented Apr 2, 2021 • edited Loading

pulpbot commented Apr 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dralley commented Apr 2, 2021 •

edited

Loading