Content contained in RepoVer and Publication #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelpicka
force-pushed
the
4832-content-with
branch
from
b2f58a8
to
4544ba0
Compare
|
Attached issue: https://pulp.plan.io/issues/4832 |
pavelpicka
force-pushed
the
4832-content-with
branch
from
4544ba0
to
3f93406
Compare
daviddavis
reviewed
Apr 9, 2021
daviddavis
reviewed
Apr 9, 2021
daviddavis
reviewed
Apr 9, 2021
daviddavis
reviewed
Apr 9, 2021
|
Some tests would be lovely 😺 |
pavelpicka
force-pushed
the
4832-content-with
branch
2 times, most recently
from
1ec294a
to
1d3cf57
Compare
mdellweg
reviewed
Apr 9, 2021
pavelpicka
force-pushed
the
4832-content-with
branch
from
1d3cf57
to
ffb956d
Compare
daviddavis
approved these changes
Apr 13, 2021
pavelpicka
force-pushed
the
4832-content-with
branch
from
ffb956d
to
0a23f4e
Compare
|
@daviddavis comment about viewset added. |
mdellweg
approved these changes
Apr 20, 2021
dralley
reviewed
Apr 20, 2021
ipanova
reviewed
Apr 21, 2021
| @@ -504,6 +532,10 @@ def versions_containing_content(cls, content): | |||
| Returns: | |||
| django.db.models.QuerySet: Repository versions which contains content. | |||
| """ | |||
| deprecation_logger( | |||
There was a problem hiding this comment.
Changelog entry extended by method goes deprecated message.
There was a problem hiding this comment.
The changes listed in CHANGES are meant for end users. We need a changelog entry for plugin writers (in CHANGES/plugin_api). Also, it should use the .deprecation extension (CHANGES/plugin_api/4832.deprecation)
There was a problem hiding this comment.
changelog divided to .feature and .deprecation
pavelpicka
force-pushed
the
4832-content-with
branch
2 times, most recently
from
cf39f8f
to
dd79126
Compare
|
I just noticed that the tests don't use bindings. It's recommended new tests should use the bindings. |
pavelpicka
force-pushed
the
4832-content-with
branch
3 times, most recently
from
e0830c8
to
93a48fb
Compare
|
tests are using bindings now |
mdellweg
reviewed
May 3, 2021
mdellweg
reviewed
May 3, 2021
ipanova
reviewed
May 5, 2021
ipanova
reviewed
May 5, 2021
| versions = list(itertools.chain.from_iterable(versions)) | ||
|
|
||
| return qs.filter(number__in=versions) | ||
| return qs.with_content([content.pk]) |
There was a problem hiding this comment.
the doc block for RepositoryVersionContentFilter is outdated
ipanova
approved these changes
May 5, 2021
pavelpicka
force-pushed
the
4832-content-with
branch
from
93a48fb
to
50c44f8
Compare
Views to show repository_versions or publications which contains specific content. closes: pulp#4832 https://pulp.plan.io/issues/4832
pavelpicka
force-pushed
the
4832-content-with
branch
from
50c44f8
to
7c7ed22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Views to show repository_versions or publications which contain specific content.
closes: #4832
https://pulp.plan.io/issues/4832