Make Handler subclassable
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
pushed a commit
to bmbouter/pulpcore-plugin
that referenced
this pull request
May 13, 2019
*breaking change!* The core now provides a handler called `BaseHandler` that is designed for subclassing. This replaces the `Handler` object for plugin-api use. This also updates the release notes since this is a breaking change. Required PR: pulp/pulpcore#130 https://pulp.plan.io/issues/4719 closes #4719
bmbouter
force-pushed
the
refactor-handler
branch
from
38dcca8
to
e085eb2
Compare
bmbouter
force-pushed
the
refactor-handler
branch
from
e085eb2
to
e38dd1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=========================================
+ Coverage 67.07% 67.18% +0.1%
=========================================
Files 64 64
Lines 3028 3029 +1
=========================================
+ Hits 2031 2035 +4
+ Misses 997 994 -3
Continue to review full report at Codecov.
|
gmbnomis
reviewed
May 15, 2019
The `Handler` object was not very subclassable, so this improves it in a few ways. - hardcoded `Handler` calls are no longer used - classmethods replace staticmethods - the HOP_BY_HOP constant is now available on the object - add a DISTRIBUTION_MODEL constant that subclasses can declare their corresponding distribution model type. If declared only that model type will be matched. If unspecified, `BaseDistribution` will be used. Unrelated to the subclassing an error case was removed which would silence all exceptions to the log which is not a good behavior. https://pulp.plan.io/issues/4719 closes pulp#4719
bmbouter
force-pushed
the
refactor-handler
branch
from
e38dd1b
to
a42ef95
Compare
|
@gmbnomis I pushed my changes from your review. |
|
LGTM now. I just set |
dkliban
approved these changes
May 15, 2019
gmbnomis
added a commit
to pulp/pulp_cookbook
that referenced
this pull request
May 15, 2019
Using the `distributon_model` attribute introduced in pulp/pulpcore#130, restrict the pulp_cookbook content app to CookbookDistributions only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Handlerobject was not very subclassable, so this improves it in afew ways.
Handlercalls are no longer usedcorresponding distribution model type. If declared only that model
type will be matched. If unspecified,
BaseDistributionwill be used.Unrelated to the subclassing an error case was removed which would
silence all exceptions to the log which is not a good behavior.
https://pulp.plan.io/issues/4719
closes #4719