Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs on how to view settings. #1348

Merged

Conversation

bmbouter
Copy link
Member

This PR also moves the configuration to its own section and out of the
installer section. The configuration has too much content to be in its
own section anymore (I think).

closes #6235

@bmbouter bmbouter force-pushed the document-how-to-show-effective-settings branch from 2eb922e to 7aa689b Compare May 19, 2021 18:12
@pulpbot
Copy link
Member

pulpbot commented May 19, 2021

Attached issue: https://pulp.plan.io/issues/6235

@bmbouter bmbouter force-pushed the document-how-to-show-effective-settings branch from 7aa689b to 0346b52 Compare May 19, 2021 21:34
Comment on lines +9 to +11
Note that settings can come from both settings file and environment variables, so when running the
``dynaconf list`` command be sure you have the same environment variables set as your Pulp
installation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGES/6235.doc Outdated
@@ -0,0 +1 @@
Added docs on how to list the effective settings using ``dyanconf list``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in dynaconf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just found one small typo.
Looks good otherwise.

This PR also moves the configuration to its own section and out of the
installer section. The configuration has too much content to be in its
own section anymore (I think).

closes #6235
@bmbouter bmbouter force-pushed the document-how-to-show-effective-settings branch from 0346b52 to ae11ee0 Compare May 20, 2021 16:06
@bmbouter bmbouter merged commit 1a02990 into pulp:master May 20, 2021
@bmbouter bmbouter deleted the document-how-to-show-effective-settings branch May 20, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants