Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: OpenAPI schema for status API is missing a response #149

Merged
merged 1 commit into from
May 22, 2019

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented May 22, 2019

Solution: add the response to the OpenAPI schema

This patch also change the operation_id from 'status_list' to 'status_read'.

fixes: #4870
https://pulp.plan.io/issues/4870

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, thanks @dkliban !

Solution: add the response to the OpenAPI schema

This patch also change the operation_id from 'status_list' to 'status_read'.

fixes: pulp#4870
https://pulp.plan.io/issues/4870
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #149 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #149      +/-   ##
=========================================
- Coverage   67.23%   67.2%   -0.04%     
=========================================
  Files          64      64              
  Lines        3034    3034              
=========================================
- Hits         2040    2039       -1     
- Misses        994     995       +1
Impacted Files Coverage Δ
pulpcore/app/views/status.py 78.72% <100%> (ø) ⬆️
pulpcore/app/viewsets/task.py 97.01% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c349d9c...4d4f26a. Read the comment docs.

@dkliban dkliban merged commit a3a4ef2 into pulp:master May 22, 2019
@dkliban dkliban deleted the status-schema branch May 22, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants