Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of repository field on Publications #152

Merged
merged 1 commit into from
May 24, 2019

Conversation

dralley
Copy link
Contributor

@dralley dralley commented May 24, 2019

closes #4792
https://pulp.plan.io/issues/4792

Since all publications are have a repository version, there is no need to display the repository field on read ops. We just want to be able to create one from the latest version of a repo.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #152 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage    67.4%   67.37%   -0.04%     
==========================================
  Files          64       64              
  Lines        3056     3056              
==========================================
- Hits         2060     2059       -1     
- Misses        996      997       +1
Impacted Files Coverage Δ
pulpcore/app/serializers/publication.py 92.77% <100%> (ø) ⬆️
pulpcore/app/models/publication.py 77.94% <0%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e1009...60dac54. Read the comment docs.

@dralley dralley merged commit 166dd73 into pulp:master May 24, 2019
@dralley dralley deleted the fix-publications branch May 24, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants