Add touch to QuerySets of artifacts or content #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha! I actually had the same idea while reviewing these plugins PRs. |
mdellweg
commented
Aug 12, 2021
| @@ -470,7 +482,7 @@ class Content(MasterModel, QueryMixin): | |||
| _artifacts = models.ManyToManyField(Artifact, through="ContentArtifact") | |||
| timestamp_of_interest = models.DateTimeField(auto_now=True) | |||
|
|
|||
| objects = ContentManager() | |||
| objects = ContentManager.from_queryset(BulkTouchQuerySet)() | |||
There was a problem hiding this comment.
If it wasn't for the content_pks parameter, i think we could move orphaned to the query set as well.
But it would change an interface now.
|
Attached issue: https://pulp.plan.io/issues/9234 |
ipanova
approved these changes
Aug 16, 2021
daviddavis
approved these changes
Aug 16, 2021
|
We believe this will get test coverage, once it's been used by #1553 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes TBA
This was just a random thought i had when writing these lines: https://github.com/pulp/pulp_container/blob/d25b01d4fb8aed1b264a9dcfc91461fe92d630b8/pulp_container/app/viewsets.py#L748
Not sure if it really helps there, also it's really kind of late for 3.14. If you like this i can do the issue dance for it.