Deprecate resources argument of dispatch #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point we can even write a migration to split the lists of resources in the two list fields in the database. |
dralley
approved these changes
Aug 18, 2021
mdellweg
force-pushed
the
exclusive_resources
branch
2 times, most recently
from
e88a452
to
f4df722
Compare
|
Attached issue: https://pulp.plan.io/issues/9257 |
mdellweg
force-pushed
the
exclusive_resources
branch
2 times, most recently
from
85281bb
to
2eb94ca
Compare
goosemania
reviewed
Aug 24, 2021
pulpcore/app/viewsets/reclaim.py
Outdated
| @@ -37,7 +37,7 @@ def reclaim(self, request): | |||
|
|
|||
| task = dispatch( | |||
| reclaim_space, | |||
| repos, | |||
| shared_resources=repos, | |||
There was a problem hiding this comment.
This seems to be out of scope of this PR. I think it has nothing to do with the deprecation but it changes the current behaviour. correct?
There was a problem hiding this comment.
Right, i'll make it a separate PR.
edit: #1574
goosemania
reviewed
Aug 24, 2021
pulpcore/app/viewsets/repository.py
Outdated
| @@ -195,7 +197,7 @@ def repair(self, request, repository_pk, number): | |||
|
|
|||
| task = dispatch( | |||
| tasks.repository.repair_version, | |||
| [version.repository], | |||
| shared_resources=[version.repository], | |||
fixes #9257
mdellweg
force-pushed
the
exclusive_resources
branch
from
2eb94ca
to
3e10dd5
Compare
goosemania
approved these changes
Aug 25, 2021
gerrod3
added a commit
to gerrod3/pulpcore
that referenced
this pull request
Aug 25, 2021
mdellweg
pushed a commit
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dralley This is based on #1526 but i'll open it for early review now.
If you think this is the way to go i'm happy to assign a ticket to it.