Improves tolerance of db connection failures in pulpcore-content #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/9515 |
dkliban
force-pushed
the
9515
branch
5 times, most recently
from
293a8ae
to
ce16351
Compare
[noissue]
dkliban
force-pushed
the
9515
branch
6 times, most recently
from
462de31
to
37b5dab
Compare
dkliban
changed the title
This patch moves Handler._reset_db_connection() call to get_base_paths_blocking(). This ensures that the connection is reset inside the same thread that is used to perform ORM calls. This fixes a bug where the /pulp/content/ page would return a 500 error after the connection the database is closed due to a network problem or a database restart. A call to Handler._reset_db_connection() has also been added to the _heartbeat() co-routine. This ensures that the heartbeat continues to be recorded in the database even if the db connection was closed. fixes: #9515 https://pulp.plan.io/issues/9515
bmbouter
reviewed
Nov 4, 2021
| class MockException(Exception): | ||
| pass | ||
|
|
||
| mock_get_or_create.side_effect = [InterfaceError(), OperationalError(), MockException()] |
mdellweg
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves Handler._reset_db_connection() call to get_base_paths_blocking(). This ensures that the
connection is reset inside the same thread that is used to perform ORM calls. This fixes a bug where the
/pulp/content/ page would return a 500 error after the connection the database is closed due to a network
problem or a database restart.
A call to Handler._reset_db_connection() has also been added to the _heartbeat() co-routine. This ensures
that the heartbeat continues to be recorded in the database even if the db connection was closed.
fixes: #9515
https://pulp.plan.io/issues/9515