Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable caching for the synchronous context #1751

Merged
merged 1 commit into from Feb 8, 2022
Merged

Enable caching for the synchronous context #1751

merged 1 commit into from Feb 8, 2022

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Dec 3, 2021

ref #8806

lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 3, 2021
@lubosmj
Store content in the Redis cache
83f4542 
ref #9500
Required PR: pulp/pulpcore#1751
@lubosmj lubosmj mentioned this pull request Dec 3, 2021
Merged
@pulpbot
Copy link
Member

pulpbot commented Dec 3, 2021

Attached issue: https://pulp.plan.io/issues/8806

lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 3, 2021
@lubosmj
Store content in the Redis cache
bb53b84 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 3, 2021
@lubosmj
Store content in the Redis cache
cc51415 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 3, 2021
@lubosmj
Store content in the Redis cache
e415f8d 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 3, 2021
@lubosmj
Store content in the Redis cache
3fac4c4 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 6, 2021
@lubosmj
Store content in the Redis cache
10f6dc0 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 6, 2021
@lubosmj
Store content in the Redis cache
7d4a663 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 6, 2021
@lubosmj
Store content in the Redis cache
bfbb2ef 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 6, 2021
@lubosmj
Store content in the Redis cache
de6cc23 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 7, 2021
@lubosmj
Store content in the Redis cache
2c1d399 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 8, 2021
@lubosmj
Store content in the Redis cache
0dda838 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 8, 2021
@lubosmj
Store content in the Redis cache
c3327a0 
ref #9500
Required PR: pulp/pulpcore#1751
@ipanova ipanova requested a review from gerrod3 December 8, 2021 12:18
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 8, 2021
@lubosmj
Store content in the Redis cache
4d27b00 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 8, 2021
@lubosmj
Store content in the Redis cache
7cd1da3 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 8, 2021
@lubosmj
Store content in the Redis cache
d5ffece 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 9, 2021
@lubosmj
Store content in the Redis cache
b82f72e 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 9, 2021
@lubosmj
Store content in the Redis cache
174f439 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 9, 2021
@lubosmj
Store content in the Redis cache
650239c 
ref #9500
Required PR: pulp/pulpcore#1751
@lubosmj lubosmj force-pushed the redis-caching-for-pc-tt branch 2 times, most recently from 367b107 to b36da97 Compare December 10, 2021 12:30
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 10, 2021
@lubosmj
Store content in the Redis cache
8dca695 
ref #9500
Required PR: pulp/pulpcore#1751
@lubosmj lubosmj force-pushed the redis-caching-for-pc-tt branch 2 times, most recently from 0880fe4 to d755870 Compare December 21, 2021 23:46
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Dec 21, 2021
@lubosmj
Store content in the Redis cache
44c346e 
ref #9500
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Jan 21, 2022
@lubosmj
Store content in the Redis cache
301c339 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Jan 25, 2022
@lubosmj
Store content in the Redis cache
c24ec4f 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Jan 25, 2022
@lubosmj
Store content in the Redis cache
007b61b 
closes pulp#496
Required PR: pulp/pulpcore#1751
@lubosmj lubosmj force-pushed the redis-caching-for-pc-tt branch 3 times, most recently from de5be8e to d59101a Compare January 31, 2022 12:54
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Jan 31, 2022
@lubosmj
Store content in the Redis cache
66c8729 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Jan 31, 2022
@lubosmj
Store content in the Redis cache
3c4c2ce 
closes pulp#496
Required PR: pulp/pulpcore#1751
@lubosmj lubosmj marked this pull request as ready for review January 31, 2022 19:49
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 1, 2022
@lubosmj
Store content in the Redis cache
f72774d 
closes pulp#496
Required PR: pulp/pulpcore#1751
gerrod3
gerrod3 reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I still want to know what is up with the hex call.

pulpcore/cache/cache.py Outdated Show resolved Hide resolved
pulpcore/cache/cache.py Outdated
Comment on lines 355 to 363
if binary := entry.pop("body", None):
entry["body"] = bytes.fromhex(binary)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still confused by this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a comment in the code would be good.

@lubosmj
Enable caching for the synchronous context
d5190cb 
In this commit, the existing method used for submitting cache entries was altered to enable caching binary data as well.

closes pulp#2003
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
21e8f95 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
461e989 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
9842481 
closes pulp#496
Required PR: pulp/pulpcore#1751
gerrod3
gerrod3 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the comment on the hex calls and it makes sense. If the response contains bytes we can't assume those bytes are 'utf-8' encoded, so converting to hex in order json encode the value for the cache makes sense.

@ipanova ipanova merged commit 53fa750 into pulp:main Feb 8, 2022
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
9567de3 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
98676b9 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 8, 2022
@lubosmj
Store content in the Redis cache
4b515f4 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to lubosmj/pulp_container that referenced this pull request Feb 9, 2022
@lubosmj
Store content in the Redis cache
f7d3edf 
closes pulp#496
Required PR: pulp/pulpcore#1751
lubosmj added a commit to pulp/pulp_container that referenced this pull request Feb 9, 2022
@lubosmj
Store content in the Redis cache
18e53b3 
closes #496
Required PR: pulp/pulpcore#1751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipanova ipanova ipanova approved these changes

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lubosmj @pulpbot @ipanova @gerrod3