Add support for chunked uploads #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue4196
branch
2 times, most recently
from
750b7d5
to
50749ea
Compare
daviddavis
force-pushed
the
issue4196
branch
2 times, most recently
from
fb1b8c1
to
701deed
Compare
dkliban
reviewed
Mar 4, 2019
dkliban
reviewed
Mar 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 76.2% 74.52% -1.69%
==========================================
Files 64 65 +1
Lines 2824 2865 +41
==========================================
- Hits 2152 2135 -17
- Misses 672 730 +58
Continue to review full report at Codecov.
|
dkliban
reviewed
Mar 5, 2019
| validated_data (dict): Data to save to the database | ||
| """ | ||
| artifact = super().create(validated_data) | ||
| if hasattr(self, 'upload'): |
There was a problem hiding this comment.
I would think that the upload attribute is always there. However it's value is None or HyperlinkedRelatedField. Is my understanding correct? In that case I would check if self.upload is None or not.
There was a problem hiding this comment.
No, the upload attribute gets optionally created in the validate method. See line 173 above.
dkliban
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4196
https://pulp.plan.io/issues/4196
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html