Use url parameter in repository access condition #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 7, 2022
[noissue] Required PR: pulp/pulpcore#1800
mdellweg
force-pushed
the
access_conditions
branch
from
5a176b1
to
b6abcc7
Compare
mdellweg
commented
Jan 7, 2022
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 7, 2022
[noissue] Required PR: pulp/pulpcore#1800
mdellweg
force-pushed
the
access_conditions
branch
from
b6abcc7
to
50b30d0
Compare
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 12, 2022
[noissue] Required PR: pulp/pulpcore#1800
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 12, 2022
[noissue] Required PR: pulp/pulpcore#1800
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 12, 2022
[noissue] Required PR: pulp/pulpcore#1800
mdellweg
force-pushed
the
access_conditions
branch
2 times, most recently
from
670fab7
to
8d6bd8c
Compare
mdellweg
changed the title
mdellweg
force-pushed
the
access_conditions
branch
2 times, most recently
from
03a3383
to
7b2af59
Compare
mdellweg
force-pushed
the
access_conditions
branch
from
7b2af59
to
9d3d621
Compare
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 13, 2022
fixes pulp#508 Required PR: pulp/pulpcore#1800
|
Attached issue: https://pulp.plan.io/issues/9670 |
gerrod3
reviewed
Jan 19, 2022
|
The difference is, that you don not need a detailed object with a repository attribute, but you can apply it to all actions that are nested under a repository viewset. The prime example is RepositoryVersionViewset where the list action could not use the existing condition. |
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 21, 2022
fixes pulp#508 Required PR: pulp/pulpcore#1800
gerrod3
approved these changes
Jan 21, 2022
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 24, 2022
[noissue] Required PR: pulp/pulpcore#1800
bmbouter
reviewed
Jan 25, 2022
| @@ -280,6 +280,68 @@ def has_repo_attr_model_or_obj_perms(request, view, action, permission): | |||
| return False | |||
|
|
|||
|
|
|||
| def has_repository_obj_perms(request, view, action, permission): | |||
There was a problem hiding this comment.
We don't have to import these through the plugin API do we?
There was a problem hiding this comment.
@mdellweg if ^ is correct go ahead and merge plz.
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 28, 2022
fixes pulp#508 Required PR: pulp/pulpcore#1800
mdellweg
added a commit
to mdellweg/pulp_container
that referenced
this pull request
Jan 28, 2022
[noissue] Required PR: pulp/pulpcore#1800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes TBA
[noissue]