Add logging around certain ways a task can fail #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/9666 |
bmbouter
reviewed
Jan 14, 2022
pulpcore/tasking/pulpcore_worker.py
Outdated
| @@ -301,6 +301,21 @@ def supervise_task(self, task): | |||
| cancel_reason = "Aborted during worker shutdown." | |||
| break | |||
| task_process.join() | |||
| if not cancel_state and task_process.exitcode != 0: | |||
| _logger.info( | |||
There was a problem hiding this comment.
What do you think about making this a warning?
This adds some logging for cases, where the task executing process dies unexpectedly (e.g. OOM) and is unable to properly set the task state and error reason. fixes #9666
mdellweg
force-pushed
the
task_logging
branch
from
3ad28ca
to
ebb5aef
Compare
bmbouter
approved these changes
Jan 14, 2022
|
@awcrosby FYI this change landing on master |
dralley
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some logging for cases, where the task executing process dies
unexpectedly (e.g. OOM) and is unable to properly set the task state and
error reason.
fixes #9666