Adds content-app to status API #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 67.31% 67.53% +0.21%
==========================================
Files 65 66 +1
Lines 3087 3123 +36
==========================================
+ Hits 2078 2109 +31
- Misses 1009 1014 +5
Continue to review full report at Codecov.
|
bmbouter
force-pushed
the
add-content-app-to-status-api
branch
4 times, most recently
from
49cb4bd
to
5bd6658
Compare
daviddavis
reviewed
Jun 24, 2019
daviddavis
reviewed
Jun 24, 2019
daviddavis
reviewed
Jun 24, 2019
daviddavis
reviewed
Jun 24, 2019
daviddavis
reviewed
Jun 24, 2019
pulpcore/app/models/status.py
Outdated
| now = timezone.now() | ||
| age_threshold = now - timedelta(seconds=settings.CONTENT_APP_TTL) | ||
|
|
||
| return self.last_heartbeat < age_threshold |
There was a problem hiding this comment.
What about returning not online() to de-dupe logic?
bmbouter
force-pushed
the
add-content-app-to-status-api
branch
from
5bd6658
to
96f6fec
Compare
A new model is introduced called `ContentAppStatus` is introduced which
will record status check-in records from the Content App.
The Content App will check in periodically checkin and write to the
`ContentAppStatus` object.
To tell the ContentAppStatus records apart for multiple Content Apps
each Content App now requires a name. The name is auto-selected as
'{pid}@{hostname}'.
The Status API viewset now shows a 'content_apps' section which lists
the ContentAppStatus records, showing their names and last heartbeat
time.
Adds a doc and feature changelog entries.
https://pulp.plan.io/issues/4881
closes pulp#4881
bmbouter
force-pushed
the
add-content-app-to-status-api
branch
from
96f6fec
to
9d6d2f2
Compare
daviddavis
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new model is introduced called
ContentAppStatusis introduced whichwill record status check-in records from the Content App.
The Content App will check in periodically checkin and write to the
ContentAppStatusobject.To tell the ContentAppStatus records apart for multiple Content Apps
each Content App now requires a name. The name is auto-selected as
'{pid}@{hostname}'.
The Status API viewset now shows a 'content_apps' section which lists
the ContentAppStatus records, showing their names and last heartbeat
time.
Adds a doc and feature changelog entries.
https://pulp.plan.io/issues/4881
closes #4881