Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry logic of partially downloaded files #1851

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix retry logic of partially downloaded files #1851

merged 1 commit into from
Jan 18, 2022

Conversation

mdellweg
Copy link
Member

fixes #9673

@mdellweg
Copy link
Member Author

This fixes a bug, when retrying partially downloaded files. However it disobeys the case where a custom_file_object was provided.

@pulpbot
Copy link
Member

pulpbot commented Jan 17, 2022

Attached issue: https://pulp.plan.io/issues/9673

@fao89 fao89 mentioned this pull request Jan 17, 2022
Closed
@dralley
Copy link
Contributor

dralley commented Jan 17, 2022

@mdellweg Needs to be updated with the github issue #

@mdellweg mdellweg linked an issue Jan 18, 2022 that may be closed by this pull request
Downloader retry logic is broken when retrying a partially written file #2078
Closed
@mdellweg mdellweg merged commit 344f616 into pulp:main Jan 18, 2022
@mdellweg mdellweg deleted the fix_downloader_retry branch January 18, 2022 11:48
@mdellweg mdellweg mentioned this pull request Jan 20, 2022
Merged
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/344f616c0d55df2c3e7d6e84bc12008942f1e8ae/pr-1851

Backported as #2136

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 20, 2022
Closed
@mdellweg mdellweg mentioned this pull request Jan 20, 2022
Closed
@fao89
Copy link
Member

fao89 commented May 17, 2022

https://bugzilla.redhat.com/show_bug.cgi?id=2033174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

@ipanova ipanova ipanova approved these changes

@fao89 fao89 fao89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloader retry logic is broken when retrying a partially written file
5 participants
@mdellweg @pulpbot @dralley @fao89 @ipanova