Remove unused field Remote.validate #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
force-pushed
the
rm-remote-validate3
branch
from
b71a963
to
f46c668
Compare
asmacdo
added a commit
to asmacdo/pulp_file
that referenced
this pull request
Jun 28, 2019
asmacdo
force-pushed
the
rm-remote-validate3
branch
from
f46c668
to
63c7184
Compare
This field was intended for plugin use, but so far plugins validate unconditionally. For now, we remove the field from core but plugins can add it on their own if they have a use for it. https://pulp.plan.io/issues/4714 fixes pulp#4714
asmacdo
force-pushed
the
rm-remote-validate3
branch
from
63c7184
to
989ddd8
Compare
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 66.56% 66.54% -0.03%
==========================================
Files 68 68
Lines 3191 3189 -2
==========================================
- Hits 2124 2122 -2
Misses 1067 1067
Continue to review full report at Codecov.
|
daviddavis
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was intended for plugin use, but so far plugins validate
unconditionally. For now, we remove the field from core but plugins can
add it on their own if they have a use for it.
Required PR: pulp/pulp_file#250
https://pulp.plan.io/issues/4714
fixes #4714