Fetch all fields when initializing a serializer #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user used _href within the fields selection, the serializer could fetch a correct value from _href. This commit removes a need to specify _href while filtering fields from the response. When the data model will change, this may cause performance drawbacks due to serializing all fields of Task objects. closes pulp#4722 https://pulp.plan.io/issues/4722
lubosmj
force-pushed
the
field-create-resources-4722
branch
from
5cfb0e7
to
ac75012
Compare
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 68.13% 68.09% -0.05%
==========================================
Files 68 68
Lines 3220 3219 -1
==========================================
- Hits 2194 2192 -2
- Misses 1026 1027 +1
Continue to review full report at Codecov.
|
dkliban
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user used _href within the fields selection,
the serializer could fetch a correct value from
_href. This commit removes a need to specify _href
while filtering fields from the response.
When the data model will change, this may cause
performance drawbacks due to serializing all fields
of Task objects.
closes #4722
https://pulp.plan.io/issues/4722